Skip to content

Detect interpolated config #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

Detect interpolated config #236

merged 1 commit into from
May 26, 2025
+22 −6

Conversation

lionello
Copy link
Member

@lionello lionello commented May 23, 2025 •
edited
Loading

Some samples require config that's interpolated and those would not get added to the sample metadata.

jordanstephens
jordanstephens approved these changes May 23, 2025
View reviewed changes
Copy link
Member

@jordanstephens jordanstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to take your word on that regexp

@lionello lionello merged commit 3ee2429 into main May 26, 2025
4 checks passed
@lionello lionello mentioned this pull request Jun 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanstephens jordanstephens jordanstephens approved these changes

@raphaeltm raphaeltm Awaiting requested review from raphaeltm

+1 more reviewer

@commit111 commit111 commit111 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lionello @jordanstephens @commit111